Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDEV-35946 Assertion `thd->is_error()' failed in Sql_cmd_dml::prepare #3808

Open
wants to merge 1 commit into
base: 11.4
Choose a base branch
from
Open

MDEV-35946 Assertion `thd->is_error()' failed in Sql_cmd_dml::prepare #3808

wants to merge 1 commit into from

Conversation

sciascid
Copy link
Contributor

  • The Jira issue number for this PR is: MDEV-35946

Description

Fix a regression that caused assertion thd->is_error() after sync wait failures. Some callers of function wsrep_sync_wait() expect an error to be set in disagnostics area, if the function returned with an error status.

Release Notes

None

How can this PR be tested?

Pull request contains a MTR test.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@sciascid
MDEV-35946 Assertion `thd->is_error()' failed in Sql_cmd_dml::prepare
94ef5de 
Fix a regression that caused assertion thd->is_error() after
sync wait failures. If wsrep_sync_wait() fails make sure a appropriate
error is set. Partially revert 75dd024.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@janlindstrom janlindstrom added the Codership Codership Galera label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sysprg sysprg

Labels
Codership Codership Galera
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sciascid @CLAassistant @janlindstrom @sysprg